Feature/set videos for smart playlists#38
Open
powpow12 wants to merge 3 commits intobrightcove:masterfrom
Open
Feature/set videos for smart playlists#38powpow12 wants to merge 3 commits intobrightcove:masterfrom
powpow12 wants to merge 3 commits intobrightcove:masterfrom
Conversation
merauluka
reviewed
Jan 2, 2019
| * @return array | ||
| * Video ids. | ||
| */ | ||
| protected function getSmartPlaylistVideos($endpoint) { |
There was a problem hiding this comment.
I have a concern that the playlist being returned doesn't appear to be honoring the optional $limit parameter. I think it needs to be incorporated here somehow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, CMS::listPlaylists() will return an array of Playlist objects but smart playlists are treated differently than manual ones. For smart playlists, the video property will be empty while manual playlists will have an array of video ids. This can cause issues downstream if developers expect them to behave the same.
The Drupal module https://cgit.drupalcode.org/brightcove/tree/?h=8.x-1.x, uses this API to save Playlist and videos into Drupal. For our use case, we would like the ability to save videos regardless of the type of playlist.
This is my first attempt and would love to hear feedback and concerns about this solution.